fix(realpath): To error out in long paths by HackingRepo · Pull Request #13223 · uutils/coreutils

HackingRepo · 2026-06-30T06:58:09Z

Sign in to view

-        if path_str.ends_with("/.") || path_str.ends_with("/./") {
-            abs.metadata()?; // raise no such file or directory error
+    for component in p.components() {
+        if let Some(name) = component.as_os_str().to_str() {


HackingRepo · 2026-06-30T07:08:42Z

@sylvestre review that

oech3 · 2026-06-30T07:09:54Z

Does this fix #13224 too?

sylvestre · 2026-06-30T07:11:35Z

@sylvestre review that

I would appreciate a more polite message
I am not a bot or an AI

HackingRepo · 2026-06-30T07:13:04Z

oh sorry, yes you are right, we need talk in a polite manner, since we are humans

sylvestre · 2026-06-30T07:19:04Z

also, please ping me only when the testsuite is green and there are tests

codspeed-hq · 2026-06-30T07:20:33Z

Merging this PR will degrade performance by 12.95%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 325 untouched benchmarks
⏩ 46 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`df_with_path`	242 µs	304.4 µs	-20.51%
❌	Simulation	`sort_ascii_c_locale`	16 ms	16.7 ms	-4.67%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing HackingRepo:patch-3 (e172782) with main (02dfaa2)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Added tests to check behavior with long path components.

github-actions · 2026-06-30T07:48:13Z

GNU testsuite comparison:

GNU test failed: tests/chmod/only-op. tests/chmod/only-op is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/pid-pipe (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

HackingRepo · 2026-06-30T10:23:04Z

Hi, @sylvestre

now all tests passed and added tests and fix working, can you merge? i appreciate it or still

sylvestre · 2026-06-30T10:27:18Z

 const OPT_RELATIVE_TO: &str = "relative-to";
 const OPT_RELATIVE_BASE: &str = "relative-base";
-
+const MAX_PATH: usize = 255;


seems low, no ?

HackingRepo · 2026-06-30T11:23:33Z

after i restore the tests, they failing that was weird, i just added the max limit then failed, i will see why

HackingRepo · 2026-06-30T11:24:23Z

the openbsd test failing because

error: extern location for proc_macro2 does not exist: /home/runner/work/coreutils/coreutils/target/debug/deps/libproc_macro2-24e159babf15897f.rlib
 --> /home/tester/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/yoke-derive-0.8.2/src/lifetimes.rs:5:5
  |
5 | use proc_macro2::Span;
  |     ^^^^^^^^^^^

error[E0463]: can't find crate for `syn`
 --> /home/tester/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/yoke-derive-0.8.2/src/lifetimes.rs:6:5
  |
6 | use syn::ext::IdentExt as _;
  |     ^^^ can't find crate

error: extern location for quote does not exist: /home/runner/work/coreutils/coreutils/target/debug/deps/libquote-c6c049b8eedf5bdc.rlib
  --> /home/tester/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/yoke-derive-0.8.2/src/lib.rs:25:5
   |
25 | use quote::quote;
   |     ^^^^^

error[E0463]: can't find crate for `synstructure`
  --> /home/tester/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/yoke-derive-0.8.2/src/lib.rs:29:5
   |
29 | use synstructure::Structure;
   |     ^^^^^^^^^^^^ can't find crate

about soomething different not about realpath at all, it causing issues

HackingRepo · 2026-06-30T13:49:07Z

the 1 failing last job, is about install unrelated fully to the pr, realpath is the thing we fixed, not install that just some problems occurs with CI/CD sometimes, ci/cd race issues sometime tests successed, however the important tests passed and only 1 job failing that happen in tons of prs. but however only 1 failing not a huge problem

HackingRepo · 2026-07-01T06:13:40Z

Hi, @sylvestre

i appreciate it, when you have time, can you please review it again all tests passes, the 1 failing is unrelated to the pr and restored previous tests and ignored rsplit to cspell not fails and now passed, can you review and merge?

sylvestre · 2026-07-01T09:35:07Z

+            .to_str()
+            .is_some_and(|name| name.len() > MAX_PATH)
+    }) {
+        return Err(Error::new(ErrorKind::InvalidInput, "File name too long"));


please use the translate! macro here

ok i will do

HackingRepo · 2026-07-03T14:43:18Z

@cakebaker what about that one? can you review it, i appreciate it

HackingRepo · 2026-07-04T09:32:38Z

hi, @sylvestre review now. i added translate! no breaking change, or logic change, so what do you think, i appreciate it, when having time

sylvestre · 2026-07-04T09:35:09Z

+            .to_str()
+            .is_some_and(|name| name.len() > MAX_PATH)
+    }) {
+        return Err(Error::new(ErrorKind::InvalidInput, translate!("File name too long")));


it isn't the way translate works
please look at other places to see how it works

sylvestre · 2026-07-04T09:35:29Z

-            abs.metadata()?; // raise no such file or directory error
+        let p_str = p.to_string_lossy();
+        let has_trailing_dot =
+            p_str.ends_with("/.") || p_str.ends_with("/..") || p_str == "." || p_str == "..";


we don't have a function already doing that in the code base ?

Enhance error handling for file name length, to match gnu

8fbf5c4

HackingRepo changed the title ~~Enhance error handling for file name length, to match gnu~~ fix(realpath): To error out in long paths Jun 30, 2026

oech3 reviewed Jun 30, 2026

View reviewed changes

HackingRepo added 2 commits June 30, 2026 07:03

Refactor code

6aa2e66

Fix caused unused variable warning

365129e

HackingRepo requested a review from oech3 June 30, 2026 07:08

sylvestre reviewed Jun 30, 2026

View reviewed changes

Comment thread src/uu/realpath/src/realpath.rs Outdated

HackingRepo added 3 commits June 30, 2026 07:21

Use MAX_PATH constant instead of 255

def010c

Add tests for long path component handling

ef238d0

Added tests to check behavior with long path components.

Fix cargo fmt issues

2b5cb41

HackingRepo requested a review from sylvestre June 30, 2026 07:57

sylvestre reviewed Jun 30, 2026

View reviewed changes

Comment thread tests/by-util/test_realpath.rs

Restore removed accidentaly tests

d4a1692

HackingRepo requested a review from sylvestre June 30, 2026 10:45

HackingRepo added 4 commits June 30, 2026 11:54

fix failing tests

1ebc41a

Fix testing issues

49d30ec

Remove 'Fix:' from comments

74de757

rsplit to ignored by spell check

82d8d64

sylvestre reviewed Jul 1, 2026

View reviewed changes

Add translate! to the error message

e172782

HackingRepo requested a review from sylvestre July 1, 2026 17:14

sylvestre reviewed Jul 4, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

HackingRepo commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

HackingRepo commented Jun 30, 2026

Uh oh!

oech3 commented Jun 30, 2026

Uh oh!

sylvestre commented Jun 30, 2026

Uh oh!

HackingRepo commented Jun 30, 2026

Uh oh!

Uh oh!

sylvestre commented Jun 30, 2026

Uh oh!

codspeed-hq Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 12.95%

Performance Changes

Footnotes

Uh oh!

github-actions Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HackingRepo commented Jun 30, 2026

Uh oh!

sylvestre Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

HackingRepo Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HackingRepo commented Jun 30, 2026

Uh oh!

HackingRepo commented Jun 30, 2026

Uh oh!

HackingRepo commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HackingRepo commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sylvestre Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

HackingRepo Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

HackingRepo commented Jul 3, 2026

Uh oh!

HackingRepo commented Jul 4, 2026

Uh oh!

sylvestre Jul 4, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Jul 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HackingRepo commented Jun 30, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 30, 2026 •

edited

Loading

github-actions Bot commented Jun 30, 2026 •

edited

Loading

HackingRepo Jun 30, 2026 •

edited

Loading

HackingRepo commented Jun 30, 2026 •

edited

Loading

HackingRepo commented Jul 1, 2026 •

edited

Loading