Implement pr#1327
Closed
tilakpatidar wants to merge 46 commits intouutils:masterfrom
Closed
Conversation
Closed
Collaborator
|
Sorry for the late response, but would you mind rebasing this? I'll try to review this in the next week or so, but just looking over the tests, some of them seem excessively long. If you could shorten them, that'd probably be ideal. |
Contributor
Author
|
I will rebase this over the weekend. I agree that some tests are excessively long but pr command contains a lot of formatting options. The test cases are copied from the gnu utils itself to ensure consistency. I will surely try to shorten them. |
pr: Add -h to print custom header instead of file name pr: Add -n to print line numbers
pr: code refactoring for references
…umbers pr: Add -l option set number of lines pr: Refactor opts
pr: Add -F to print line feed character for page separator
pr: Fix number of lines printed per page pr: Fix first short page getting skipped due to page range
pr: Remove parameter header from build_options pr: Remove unnecessary get_input_type
pr: Add test for -h option pr: Add test for -d option
pr: Fix long name for -n pr: Add -N first line number option pr: Add -n[char][width] support
pr: Fix page ranges
pr: Add test for -l option pr: Add test for -r suppress error option
pr: Print fixed padded string for each column pr: Fix display length vs str length due to tabs
pr: Add -o option
pr: Remove unwanted brancing in fill_missing_lines pr: Remove unnecessary error check pr: Rename key to group_key in FileLine pr: Reformat test_pr with rustfmt
pr: fix form feed pr: Rustfmt pr: add test for ff and -l option
pr: add -J option pr: add -S option
pr: refactor batching of pages in pr
pr: refactor common iterator between pr and mpr pr: remove fill lines in mpr
pr: extract recreate_arguments pr: refactor get_line_for_printing pr: refactor get_lines_for_printing pr: refactor fetch_indexes generate for write_columns pr: refactor write_columns pr: refactor write_columns
rivy
force-pushed
the
master
branch
4 times, most recently
from
f07992e to
813e57d
Compare
Contributor
|
@tilakpatidar Sorry, I am just taking over the maintenance of coreutils. Are you still interested in landing it? If so, could you please rebase your change? thanks |
Contributor
|
Moved here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.