Refactor/code quality

[danieleades]

Addresses a number of code quality lints.

I haven't added any additional lints/checks to enforce these changes. Is that something that you want?

[sylvestre]

I like most of the change. thanks :)
However, I am not convinced by the match => if
In general, I prefer the match

Could you please remove this commit from the pr?
thanks

[danieleades]

I like most of the change. thanks :) However, I am not convinced by the match => if In general, I prefer the match

Could you please remove this commit from the pr? thanks

sure thing. I've removed that commit.

[tertsdiepraam]

Hey! Great job! This is getting pretty big, let's split it here and put further changes in another PR. Oh you we're faster than me :)

[danieleades]

Hey! Great job! This is getting pretty big, let's split it here and put further changes in another PR. Oh you we're faster than me :)

sure. happy to slice and dice this however you like! Will move further changes to a stacked PR

[tertsdiepraam]

Looks all good to me!

I haven't added any additional lints/checks to enforce these changes. Is that something that you want?

Possibly, though probably not for all of these changes. For example, always using Default might hurt readability in some cases, because it's less explicit and requires contributors to know the default value for a lot of (possibly obscure) types. I'm fine with sticking to clippy's default settings for now.

[danieleades]

CI failures...
I don't think they're related to this PR. how stable is the CI normally?

[tertsdiepraam]

It's pretty stable these days, but it fails every once in a while. It seems unrelated indeed. I'll rerun the CI

[danieleades]

It's pretty stable these days, but it fails every once in a while. It seems unrelated indeed. I'll rerun the CI

loads of failures in GnuTests job. Still think it's unrelated to this PR? I can split the commits into separate PRs if it helps?

[tertsdiepraam]

loads of failures in GnuTests job

That's to be expected. This tests against all GNU tests and we are not 100% compatible. The job will fail if there are any tests that pass on main but not on the PR.

[tertsdiepraam]

I've created an issue for the test that failed: #2969

[danieleades]

@tertsdiepraam
finished! that's some epic CI

[sylvestre]

what tool did you use for that btw?

[danieleades]

what tool did you use for that btw?

it was about 5% manual effort, and about 95% clippy

[sylvestre]

I guess it is with inactivated options of clippy as we have it in the CI?
Could you please update the CI to enable them?
thanks