cat: minor cleanups#3145
Merged
tertsdiepraam merged 3 commits intomainfrom Feb 16, 2022
unknown repository
Merged
Conversation
Contributor
|
what is a review group ? :) |
Author
Together with a few people we meet once a week to review code. This is our first project to look into :)
Sorry 🙈 - of course I will do that |
The logic for '\n' and '\r' about the number of written characters was duplicated
Author
|
@sylvestre I am not sure how it is usually handled with force-pushing vs. append-only in this project and I couldn't find anything in CONTRIBUTING.md. I hope with this small patch-set it is relatively easy to look at anyways... |
sylvestre
reviewed
Feb 15, 2022
Member
|
Both are fine! If you force push we can merge it directly and if you add commits we'll probably squash and merge. |
This type is already handled by get_input_type, so we can unify the handling
Member
|
Thank you! |
Author
|
Thank all of you for maintaining this great project! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our code review group we found a few minor simplifications :)