Skip to content

Conversation

@cakebaker
Copy link
Contributor

No description provided.

@cakebaker cakebaker marked this pull request as draft July 30, 2024 13:14
@cakebaker cakebaker changed the title uucore: use workspace = true for dns-lookup Use workspace = true for some dependencies Jul 30, 2024
@cakebaker cakebaker marked this pull request as ready for review July 30, 2024 13:36
@BenWiederhake
Copy link
Collaborator

Why are only some workspace = true, but not others? (I honestly don't know why we sometimes decide in favor and sometimes against inheriting the versions from the overall workspace.)

@cakebaker
Copy link
Contributor Author

Hm, good question. I think we don't add dependencies as workspace dependencies if they are a dev dependency only. And in the case of uucore if the dependency is only used there.

@sylvestre sylvestre merged commit e33cecd into uutils:main Aug 2, 2024
@cakebaker cakebaker deleted the uucore_use_workspace_dependency branch August 2, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants