fix(date): support ISO-8601 with 12-hour time#9275
Open
naoNao89 wants to merge 1 commit intouutils:mainfrom
Open
fix(date): support ISO-8601 with 12-hour time#9275naoNao89 wants to merge 1 commit intouutils:mainfrom
naoNao89 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
fix/date-iso8601-12hour-time-9253
branch
from
7279fd4 to
49d348f
Compare
The parse_datetime crate's combined parser only accepts 24-hour time. When parsing "YYYY-MM-DD HH:MMam/pm", it fails because the ISO time parser doesn't support meridiem indicators. Normalize by converting dashes to slashes (YYYY-MM-DD → YYYY/MM/DD) which forces separate parsing where 12-hour time is supported. Implementation uses zero-allocation string slicing for efficiency. Fixes uutils#9253
naoNao89
force-pushed
the
fix/date-iso8601-12hour-time-9253
branch
from
49d348f to
ad73e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes parsing of ISO-8601 dates with 12-hour time (e.g.,
2025-01-01 12:00am).The
parse_datetimecrate's combined parser only accepts 24-hour format. Workaround converts dash-separated dates to slashes when 12-hour time is detected, forcing separate parsing where am/pm is supported.Fixes #9253