ls: long mode format needs additional space when security or FACL symbol is present.#9913
Open
sgmarz wants to merge 3 commits intouutils:mainfrom
Open
ls: long mode format needs additional space when security or FACL symbol is present.#9913sgmarz wants to merge 3 commits intouutils:mainfrom
sgmarz wants to merge 3 commits intouutils:mainfrom
Conversation
…FACL (+) indicator symbols are not present in long output format.
Contributor
|
sorry, it needs to be rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR fixes issue #9912.
There is now an added
elsestatement insrc/uu/ls/src/ls.rsif neither the security context nor FACL symbols are present to add two spaces instead of just one.This patch is minimally invasive, however the testing suite was also updated to allow for the . or + symbols as well as a space. Simply, the regex in test_ls.rs was changed from
[.+]?to[.+ ]?.With this PR, the columns now line up properly even when the security context (.) or FACL symbols (+) are present or mixed as demonstrated below: