E2e bench only#17
Merged
Merged
Conversation
Replace the matcher micro-benchmarks with a single end-to-end 'search' group driven through uumain over a multi-megabyte file: a literal pattern (which a buffer-at-a-time searcher can accelerate) and an extended-regex control (which cannot). Matching pre-split lines in isolation cannot reveal how the searcher feeds data to the matcher; this does.
Cover the real-world grep usage shapes from the tldr page end-to-end through uumain over a shared multi-MB corpus (plus a directory with a binary file for -rI): search pattern, -F fixed string, -rI recursive ignoring binary, -C 3 context, -Hn --color=always, -o only-matching, -v invert, -Ei extended + ignore-case. Kept alongside the pure-scan throughput benches (literal vs regex, no match). A rare marker keeps matched output small so the full-file scan dominates the timing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 6 6
Lines 1422 1422
Branches 140 140
=======================================
Hits 1355 1355
Misses 66 66
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will create unknown performance changes
Performance Changes
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.