grep: reject conflicting matcher flags#47
Open
wondr-wclabs wants to merge 1 commit into
Open
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
e746cf4 to
97105be
Compare
97105be to
2a9296c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
GNU grep treats matcher selection as a choice between modes:
-F,-E,-G, and-Pcan each be repeated idempotently, but mixing different modes is a usage error. The old parser model used Clap overrides, which made mixed modes silently become “last flag wins.”This changes the parser to preserve which matcher flags were present and then performs a small GNU-style validation step in
uumain. I used custom validation instead of Clap conflicts so the diagnostic matches the behavior described in the issue (conflicting matchers specified) while still accepting repeated identical flags such as-F -Fand-E -E.The regression test covers the listed mixed-mode combinations, a long-option pair, and repeated same-mode controls.