grep: warn on leading ERE repeat operators#48
Open
wondr-wclabs wants to merge 1 commit into
Open
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
21cf159 to
261a0bc
Compare
261a0bc to
0f16075
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
GNU grep accepts leading ERE repeat operators as a warning case rather than a hard regex compile error. The operator is effectively ignored, so a pattern like
?or{2}becomes an empty match and still selects the input line.This keeps the compatibility change deliberately narrow: instead of disabling Oniguruma’s invalid-repeat handling globally, it detects only the leading ERE repeat forms described in the issue, emits the GNU-style warning, and compiles the remaining pattern normally. That preserves existing BRE behavior such as treating
*fooas a literal basic-regexp pattern, and it avoids changing unrelated independent-repeat cases in the regex engine.The regression test covers
?,*,+,{2}, and{,2}in ERE mode, plus a BRE*foocontrol case.