grep: support \s and \S in BRE mode#51
Closed
wondr-wclabs wants to merge 1 commit into
Closed
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31.
This enables Oniguruma's whitespace escape operator for
RegexMode::Basicso GNU BRE extensions\sand\Sare recognized in the default-Gmode. The change is intentionally scoped to BRE: fixed-string mode should stay literal, ERE already usesSyntax::gnu_regex(), and PCRE has its own syntax path.I chose the Onig syntax flag rather than pre-processing patterns because it keeps escaping semantics inside the regex engine and avoids hand-maintaining a second parser for these shorthands. The new test cases live in the existing
bre_gnu_extensionscoverage alongside other GNU BRE extensions.Validation run locally:
cargo fmt --all -- --checkcargo test bre_gnu_extensions -- --nocaptureprintf 'a b\nxy\n' | cargo run --quiet -- -e '\s'->a bprintf 'aS b\n \nx\n' | cargo run --quiet -- -c '\S'->2cargo testcargo test --no-fail-fastcargo clippy --all-targets --workspace -p uu_grep -- -D warningsgit diff --check