bench: use seeded RNG for glass_pumpkin prime generation benchmarks#57
Merged
sylvestre merged 1 commit intouutils:mainfrom Feb 20, 2026
Merged
bench: use seeded RNG for glass_pumpkin prime generation benchmarks#57sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
Use glass_pumpkin's from_rng() API with a seeded ChaCha8Rng instead of new() which uses OsRng internally, making these benchmarks deterministic. num-primes doesn't expose an RNG parameter so it remains non-deterministic.
Contributor
Merging this PR will degrade performance by 92.34%
Performance Changes
Comparing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 78.64% 84.66% +6.01%
==========================================
Files 13 14 +1
Lines 2585 3403 +818
Branches 230 238 +8
==========================================
+ Hits 2033 2881 +848
+ Misses 552 521 -31
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use glass_pumpkin's from_rng() API with a seeded ChaCha8Rng instead of new() which uses OsRng internally, making these benchmarks deterministic. num-primes doesn't expose an RNG parameter so it remains non-deterministic.