Skip to content

Cargo.toml: use same optimization with uutils/factor for bench#69

Open
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:patch-1
Open

Cargo.toml: use same optimization with uutils/factor for bench#69
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:patch-1

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 26, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.15%. Comparing base (3f5db7d) to head (6afd61b).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   78.64%   85.15%   +6.51%     
==========================================
  Files          13       15       +2     
  Lines        2585     3490     +905     
  Branches      230      246      +16     
==========================================
+ Hits         2033     2972     +939     
+ Misses        552      518      -34     
Flag Coverage Δ
macos_latest 85.07% <ø> (+7.43%) ⬆️
ubuntu_latest 84.55% <ø> (+6.37%) ⬆️
windows_latest 17.33% <ø> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq bot commented Mar 26, 2026

Merging this PR will improve performance by 10.97%

⚡ 1 improved benchmark
✅ 19 untouched benchmarks
⏩ 9 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation glass_pumpkin (BPSW) 9.2 µs 8.3 µs +10.97%

Comparing oech3:patch-1 (6afd61b) with main (afac996)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 marked this pull request as ready for review March 26, 2026 18:10
@xtqqczze
Copy link
Copy Markdown
Contributor

num-prime is used not just by coreutils, could this be justified on it's own merits?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 26, 2026

I guess optimization is applied for this crate when this is used by other projects missing profile.
It does not appear on the comment, but num-prime 's perf gained 6%.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 27, 2026

It seems #69 (comment) is inccorrect. I'm not sure is i possible, but it might better to apply only for CodSpeed.

@xtqqczze
Copy link
Copy Markdown
Contributor

This is a library crate, do optimization settings have any effect when used as a dependency?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 27, 2026

I'm not sure. maybe, no. So this is useful only for benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants