Skip to content

fix: keep in-place suffix attached#433

Open
MukundaKatta wants to merge 1 commit into
uutils:mainfrom
MukundaKatta:codex/fix-in-place-suffix-spacing
Open

fix: keep in-place suffix attached#433
MukundaKatta wants to merge 1 commit into
uutils:mainfrom
MukundaKatta:codex/fix-in-place-suffix-spacing

Conversation

@MukundaKatta
Copy link
Copy Markdown

Summary

  • prevent -i / --in-place from consuming the next argument as a backup suffix
  • keep GNU-compatible attached suffix forms working (-i.bak, --in-place=.bak)
  • update in-place and symlink backup tests to use attached suffixes
  • add regression coverage for -i script file editing without a backup

Fixes #425.

Tests

  • cargo fmt --check
  • manual reproduction: cargo run --quiet -- -i 's/fox/vox/' <file>
  • manual suffix checks for -i.bak and --in-place=.bak
  • cargo test in_place
  • cargo test test_sed
  • cargo test

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.31%. Comparing base (f083fa0) to head (79b811b).

Files with missing lines Patch % Lines
src/sed/mod.rs 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   82.20%   82.31%   +0.10%     
==========================================
  Files          13       13              
  Lines        5542     5574      +32     
  Branches      310      313       +3     
==========================================
+ Hits         4556     4588      +32     
  Misses        983      983              
  Partials        3        3              
Flag Coverage Δ
macos_latest 82.99% <97.22%> (+0.10%) ⬆️
ubuntu_latest 83.09% <97.22%> (+0.09%) ⬆️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will degrade performance by 5.77%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 9 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
number_fix 517.8 ms 598.9 ms -13.53%
access_log_subst 1.2 s 1.1 s +2.69%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing MukundaKatta:codex/fix-in-place-suffix-spacing (79b811b) with main (f083fa0)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in-place option uses different format

1 participant