fast_io.rs: replace the unsafe libc::copy_file_range call by rustix#458
Open
Franklin-Qi wants to merge 1 commit into
Open
fast_io.rs: replace the unsafe libc::copy_file_range call by rustix#458Franklin-Qi wants to merge 1 commit into
libc::copy_file_range call by rustix#458Franklin-Qi wants to merge 1 commit into
Conversation
Franklin-Qi
changed the title
libc::copy_file_range call by rustixlibc::copy_file_range call by rustix
Replace the unsafe `libc::copy_file_range` call with the safe `rustix::fs::copy_file_range`. Closes: uutils#442
Franklin-Qi
force-pushed
the
fix-#442-replace-unsafe-libc-function-by-rustix
branch
from
178f2d9 to
115b6b6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 82.18% 82.29% +0.10%
==========================================
Files 13 13
Lines 5551 5585 +34
Branches 312 310 -2
==========================================
+ Hits 4562 4596 +34
Misses 986 986
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sylvestre
reviewed
Jun 5, 2026
| } | ||
|
|
||
| #[test] | ||
| #[cfg(all(target_os = "linux", target_env = "gnu"))] |
Contributor
There was a problem hiding this comment.
target_env isn't necessary
sylvestre
reviewed
Jun 5, 2026
| break; | ||
| let mut in_off_u64 = in_off as u64; | ||
| let result: std::io::Result<usize> = rustix_copy_file_range( | ||
| unsafe { BorrowedFd::borrow_raw(in_fd) }, |
Contributor
There was a problem hiding this comment.
can we avoid these two unsafe ?
Author
There was a problem hiding this comment.
Thanks for the review; I'll remove those two unsafe blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the unsafe
libc::copy_file_rangecall with the saferustix::fs::copy_file_rangeAPI to improve safety and reduce unsafe code surface.
Closes: #442