Skip to content

feat(last): add --since and --until#342

Merged
cakebaker merged 10 commits intouutils:mainfrom
sbentmar:add-since-and-until
Aug 1, 2025
Merged

feat(last): add --since and --until#342
cakebaker merged 10 commits intouutils:mainfrom
sbentmar:add-since-and-until

Conversation

@sbentmar
Copy link
Copy Markdown
Contributor

Resolves #213

Comment thread src/uu/last/src/last.rs
Comment thread src/uu/last/src/platform/unix.rs Outdated
Copy link
Copy Markdown
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests would be nice to ensure that we don't regress in the future.

@sylvestre sylvestre force-pushed the add-since-and-until branch from 9f535bc to 1a51a6e Compare July 30, 2025 08:32
@sbentmar sbentmar force-pushed the add-since-and-until branch from 1a51a6e to 905f833 Compare July 31, 2025 22:29
@sbentmar sbentmar force-pushed the add-since-and-until branch from f8d065e to 69d9961 Compare July 31, 2025 22:36
@sbentmar
Copy link
Copy Markdown
Contributor Author

@cakebaker

  • added tests
  • refactored parse_time_value to use early returns
  • moved defaults to the uumain function

@sbentmar sbentmar requested a review from cakebaker August 1, 2025 14:02
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests :)

@cakebaker cakebaker merged commit b5d6d18 into uutils:main Aug 1, 2025
13 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (c544b4a) to head (3f81edd).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #342   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cakebaker
Copy link
Copy Markdown
Contributor

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

last: add options --since and --until

2 participants