Why use plugins instead of enable/disable checkboxes in preferences?

[ankostis]

I've been trying to add support for pandas-dataframes and I stumbled upon this architectural issue:

Reading pandas-dataframes obviously require pandas as dependency. For features demanding extra dependencies the setuptools plugin mechanism is a perfect match: just add a new extras_require={'dataframes': 'pandas'} and the job is done.

But strangely, "plugins" are used as an elaborate method for on/off behavior; is there any reason not to preserve the setuptools semantics? that is:

• are dependencies installed? plugin is enabled.
• On/Off functionality is provided by separate preferences checkboxes that appear only if plugin installed.

Note that setuptools plugins maybe also be installed from folder.

[uvemas]

Yes, you are right. Automatically enabling plugins if dependencies are installed should be the way to go. I add it to my TODO.

[ankostis]

Additionally, why is CSV functionality a plugin?

[uvemas]

What's wrong with it? Why do you think it should be part of the ViTables' core?

[ankostis]

CSV functionality for dataframes is very easy to offer, but to reuse the menu items it needs the plug-in enabled.
A plug-in that has no extra dependencies, just code that offers a very useful functionality. So why not add it to the core and simplify things?

[uvemas]

I see your point. I have to rethink the whole plugins thing. Anyway, if it helps you I'll add CSV to the main code, but not this weekend (I've not even a computer here, just my smartphone)

On Sat, Jul 8, 2017, 19:08 Kostis Anagnostopoulos ***@***.***> wrote: CSV functionality for dataframes is very easy to offer, but to reuse the menu items it needs the plug-in enabled. A plug-in that has no extra dependencies, just code that offers a very useful functionality. So why not add it to the core and simplify things? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#72 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDHCaBbVJvhmioHNSYYvQblPrMlHXSaks5sL7eXgaJpZM4N58S7> .

-- Share what you know, learn what you don't

[uvemas]

The CSV capabilities have been added to the core. Hope that helps you.