Integrate SpaceWS (#185) #186
Conversation
Enable campus location support
There was a problem hiding this comment.
Pull request overview
This PR integrates the SpaceWS service to enable campus location support. The integration includes adding the UW-RestClients-Space dependency, configuring environment variables for the Space service, and implementing functionality to fetch and process campus building/location data from the Space API.
- Adds UW-RestClients-Space package dependency and environment configuration
- Implements data access layer to query SpaceWS for campus facilities/buildings
- Creates management command to identify location renames and generate import CSV files
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Adds UW-RestClients-Space~=1.2 package dependency |
| docker/test-values.yml | Configures SPACE_ENV and SPACE_TIMEOUT environment variables for test environment |
| docker/prod-values.yml | Configures SPACE_ENV and SPACE_TIMEOUT environment variables for production environment |
| accountsynchr/dao/campus_location.py | Implements CampusLocation class and function to fetch/parse campus location data from SpaceWS |
| accountsynchr/management/commands/update_location.py | Creates Django management command to process campus locations and generate CSV output |
| accountsynchr/tests/dao/test_campus_location.py | Adds unit tests for campus location data access functionality |
| accountsynchr/data/campus_location_export.csv | Provides CSV export of 310+ campus locations with names, map links, and coordinates |
| .github/workflows/cicd.yml | Updates CI/CD workflow to include feat/location branch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if len(fac_objs) > 1: | ||
| logger.error( | ||
| f"search_by_name {self.old_name} " + | ||
| f"ULTI-MATCHES: {fac_objs}" |
There was a problem hiding this comment.
Corrected spelling of 'ULTI-MATCHES' to 'MULTI-MATCHES'.
| f"ULTI-MATCHES: {fac_objs}" | |
| f"MULTI-MATCHES: {fac_objs}" |
| 'uw-memcached-clients~=1.1', | ||
| 'UW-RestClients-Core~=1.4', | ||
| 'UW-RestClients-GWS~=2.3', | ||
| 'UW-RestClients-Space==1.2.5', |
There was a problem hiding this comment.
Using exact version pinning (==) for dependencies can cause issues with compatibility and updates. Consider using compatible release (=) instead to allow patch updates while maintaining compatibility, e.g., 'UW-RestClients-Space=1.2'.
| 'UW-RestClients-Space==1.2.5', | |
| 'UW-RestClients-Space~=1.2.5', |
Enable campus location support