fix: decoder bug when a null column is not last #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.2.4 added null column support (7b9b5eb), but the encoder/decoder got out of sync. Encoder wrote field nodes for null columns, decoder didn't read them. Result: columns after null-type columns read wrong field nodes and got corrupted. Added tests and test file as well.
Contributor
Author
|
@jheer for when you have a moment, it's a small bugfix to the null-column support added in previous PR. |
jheer
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.2.4 added null column support (7b9b5eb), but the decoder got out of sync. Encoder wrote field nodes for null columns, decoder didn't read them. Result: columns after null-type columns read wrong field nodes and got corrupted.
This fixes that. Added tests and test file as well.