fix: MosaicClient types #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoh
changed the title
kwonoh
force-pushed
the
fix-type-filterBy
branch
from
4002ef4 to
ff04126
Compare
kwonoh
force-pushed
the
fix-type-filterBy
branch
from
ff04126 to
abe7284
Compare
kwonoh
force-pushed
the
fix-type-filterBy
branch
2 times, most recently
from
095174d to
d7c8188
Compare
kwonoh
force-pushed
the
fix-type-filterBy
branch
from
d7c8188 to
3fb9c5f
Compare
Collaborator
Author
Member
|
They seems to be something with the order of tests. Somewhere we need to first install the extension. I've seen this before so it's probably safe to ignore for now. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the type definitions in MosaicClient by updating JSDoc annotations and union types for properties.
- Updated the type for _filterBy to allow undefined.
- Revised the types for _coordinator and _request to include null.
- Updated getter methods to reflect the new types.
domoritz
approved these changes
Apr 3, 2025
Member
domoritz
left a comment
domoritz
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.