Support Regular Lon/Lat Grids for OpenIFS Tasks #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- map tasks work as expected - timeseries task does not work
- moved area weight computation into cubes.py (should this be somewhere else?) - regular grid area weights computed based on Iris user guide: https://scitools-iris.readthedocs.io/en/latest/userguide/cube_statistics.html - changed the bounds used in compute_spatial_mean(), since this caused an error. I am not really sure why it was 0, 2 for longitudes before, was this a bug?
Collaborator
Author
|
Failing tests are again due to something with |
uwefladrich
approved these changes
Oct 28, 2025
Owner
uwefladrich
left a comment
uwefladrich
left a comment
There was a problem hiding this comment.
Code changes look good to me! But of course, I haven't tested. Trust in you! 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118
cubes.py. Should we come up with a better place?