Removed archiver and replaced with native golang#108
Merged
Conversation
Contributor
|
thanks i will try to review over the weekend or next week |
Contributor
Author
|
That's ace, thank you! |
cpanato
approved these changes
Dec 20, 2024
Contributor
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
cool
seems ok to me
thanks!
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
Contributor
Author
|
Oh brilliant, thank you! Do you know if/when you plan to cut a new release, just so I can keep porter up to date with the changes? Cheers! |
Contributor
|
maybe next week, need to check other things before, but while that you can point to the main branch your go.mod and run tests :) |
Contributor
Author
|
Oh brilliant, thanks for the confirm. Yup, I have our repos pointing at the commit and all tests are passing, so we're looking good :) |
Contributor
Member
|
This was on the backlog for me, so thanks for the contribution, @dgannon991! |
Contributor
Author
|
No worries at all, always happy to help :) Thank you both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use magex in porter (https://github.com/getporter/porter) and recently we've had a few high severity warnings relating to the use or archiver.
First I attempted to use their replacement package (archives) but found it still had a vast number of vulnerabilities reported by RHDA. Here I've gone with a simple native golang implementation, so hopefully that keeps the numbers down in the future!
This delivers towards getporter/porter#3282