Resolve ambiguous return in __red_by_seg_op in SYCL backend
#2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
mmichel11
requested review from
MikeDvorskiy,
SergeyKopienko,
adamfidel,
danhoeflinger and
dmitriy-sobolev
adamfidel
reviewed
Apr 30, 2025
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
timmiesmith
pushed a commit
that referenced
this pull request
Jun 9, 2025
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
danhoeflinger
pushed a commit
that referenced
this pull request
Oct 29, 2025
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__red_by_seg_ophas a potential ambiguous return when the return type of__binary_opdiffers from the input segment's underlying value type. To resolve this issue, we can ensure the second element in the tuple returned by__red_by_seg_opmatches the return type of__binary_opthrough a conversion.In practice, this issue was encountered when performing a
reduce_by_segmentoperation over zip iterators where astd::tupleis explicitly returned by the reduction operator. I have added a test case which catches this issue inreduce_by_segment_zip.pass