-
Notifications
You must be signed in to change notification settings - Fork 178
Overriding CMAKE_BUILD_TYPE #3
Copy link
Copy link
Closed
Labels
acceptedThe issue/feature is confirmed and going to be implementedThe issue/feature is confirmed and going to be implementedbugA request to fix an issueA request to fix an issuebuildA request to change/fix/improve the build systemA request to change/fix/improve the build system
Metadata
Metadata
Assignees
Labels
acceptedThe issue/feature is confirmed and going to be implementedThe issue/feature is confirmed and going to be implementedbugA request to fix an issueA request to fix an issuebuildA request to change/fix/improve the build systemA request to change/fix/improve the build system
The following code:
https://github.com/oneapi-src/oneMKL/blob/7f40c123571995d2e89a910e7844145ec91cd937/CMakeLists.txt#L26-L32
overrides the default
CMAKE_BUILD_TYPEpassed by the command line, and expect users to useBUILD_DEBUGflag. Is not really the way CMake users expect to build the programs, some may say is not idiomatic. In practice, it causes some conflicts with Jenkins scripts and user expectations about building the project.Is there any particular reason for this? otherwise,
CMAKE_BUILD_TYPEshould be enough to cover for the use case...