Skip to content

fix: Make release signing configuration lazy to fix CI builds #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graycreate merged 1 commit into from
Jul 21, 2025
Merged

fix: Make release signing configuration lazy to fix CI builds #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,10 @@ android {
release {
// Release signing requires environment variables to be set
// The keystore will be decoded from KEYSTORE_BASE64 in CI/CD
if (System.getenv("KEYSTORE_PASSWORD") != null && System.getenv("KEY_PASSWORD") != null) {
storeFile file("keystore.jks")
storePassword System.getenv("KEYSTORE_PASSWORD")
keyAlias System.getenv("KEY_ALIAS")?.trim() ?: "ghui"
keyPassword System.getenv("KEY_PASSWORD")
} else {
// Release builds require proper environment variables
throw new GradleException("Release builds require signing configuration. Please set KEYSTORE_PASSWORD and KEY_PASSWORD environment variables.")
}
storeFile file("keystore.jks")
storePassword System.getenv("KEYSTORE_PASSWORD") ?: ""
keyAlias System.getenv("KEY_ALIAS")?.trim() ?: "ghui"
keyPassword System.getenv("KEY_PASSWORD") ?: ""
}
}

Expand Down
Loading