Skip to content

Fix build issues by removing unused Condom library #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2025
Merged

Fix build issues by removing unused Condom library #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2afc382
fix: remove unused Condom library to fix build issues
graycreate Sep 9, 2025
ab1cf2c
fix: resolve Glide 4.16.0 compatibility issues for image loading
graycreate Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ dependencies {
implementation 'com.github.bumptech.glide:okhttp3-integration:4.16.0'
implementation 'pub.devrel:easypermissions:3.0.0'
implementation 'org.greenrobot:eventbus:3.3.1'
implementation 'com.github.oasisfeng:condom:2.5.0'
// Temporarily disabled due to JitPack issues
// implementation 'com.github.oasisfeng:condom:2.5.0'
implementation 'org.slf4j:slf4j-nop:2.0.17'
implementation 'androidx.core:core-splashscreen:1.0.1'
}
1 change: 0 additions & 1 deletion app/src/main/java/me/ghui/v2er/general/App.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import androidx.annotation.Nullable;

import com.oasisfeng.condom.CondomContext;
import com.orhanobut.logger.AndroidLogAdapter;
import com.orhanobut.logger.FormatStrategy;
import com.orhanobut.logger.Logger;
Expand Down
7 changes: 6 additions & 1 deletion app/src/main/java/me/ghui/v2er/general/MyAppGllideModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,16 @@

@GlideModule
public class MyAppGllideModule extends AppGlideModule {

@Override
public boolean isManifestParsingEnabled() {
return false;
}

@Override
public void registerComponents(Context context, Glide glide, Registry registry) {
OkHttpUrlLoader.Factory factory = new OkHttpUrlLoader.Factory(APIService.httpClient());
glide.getRegistry().replace(GlideUrl.class, InputStream.class, factory);
registry.replace(GlideUrl.class, InputStream.class, factory);
Copy link

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from glide.getRegistry().replace() to registry.replace() is correct, but you should verify that the registry parameter is not null before using it, as this could cause a NullPointerException if Glide passes a null registry.

Suggested change
registry.replace(GlideUrl.class, InputStream.class, factory);
if (registry != null) {
registry.replace(GlideUrl.class, InputStream.class, factory);
}

Copilot uses AI. Check for mistakes.
}

@Override
Expand Down
Loading