Skip to content

fix: replace wget with curl for bundletool download #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graycreate merged 1 commit into from
Sep 9, 2025
Merged

fix: replace wget with curl for bundletool download #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,13 @@ jobs:

# Download bundletool
echo "Downloading bundletool..."
wget -q https://github.com/google/bundletool/releases/latest/download/bundletool-all.jar
curl -L -o bundletool-all.jar https://github.com/google/bundletool/releases/latest/download/bundletool-all.jar
Copy link

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding the --fail flag to curl to ensure it returns a non-zero exit code on HTTP errors, which would make the command fail fast on download errors instead of potentially creating an empty or error file.

Suggested change
curl -L -o bundletool-all.jar https://github.com/google/bundletool/releases/latest/download/bundletool-all.jar
curl -L --fail -o bundletool-all.jar https://github.com/google/bundletool/releases/latest/download/bundletool-all.jar

Copilot uses AI. Check for mistakes.

# Verify download
if [ ! -f bundletool-all.jar ]; then
echo "Failed to download bundletool"
exit 1
fi

# Create a dummy debug keystore for bundletool (required for APK generation)
echo "Creating dummy keystore..."
Expand Down
Loading