fix: replace wget with curl for bundletool download #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace wget with curl which has better error handling - Add verification step to ensure bundletool was downloaded - Use -L flag to follow redirects properly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
Replace wget with curl for downloading bundletool in the GitHub Actions release workflow to fix download failures.
- Replaced wget command with curl for bundletool download
- Added download verification to ensure bundletool file exists before proceeding
- Improved error handling with explicit exit on download failure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # Download bundletool | ||
| echo "Downloading bundletool..." | ||
| wget -q https://github.com/google/bundletool/releases/latest/download/bundletool-all.jar | ||
| curl -L -o bundletool-all.jar https://github.com/google/bundletool/releases/latest/download/bundletool-all.jar |
There was a problem hiding this comment.
Consider adding the --fail flag to curl to ensure it returns a non-zero exit code on HTTP errors, which would make the command fail fast on download errors instead of potentially creating an empty or error file.
Suggested change
| curl -L -o bundletool-all.jar https://github.com/google/bundletool/releases/latest/download/bundletool-all.jar | |
| curl -L --fail -o bundletool-all.jar https://github.com/google/bundletool/releases/latest/download/bundletool-all.jar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bundletool download failure by using curl instead of wget