fix: hide section titles in Explore tab before content loads #107
+56
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only show section titles when the corresponding data is available, preventing empty section headers from appearing during initial load. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI issue where section titles appeared in the Explore tab even when their corresponding data hadn't loaded yet, resulting in empty headers during the initial network loading phase.
Key Changes:
- Wrapped all four sections in conditional statements that check if their respective data arrays are non-empty before rendering
- Applied the same pattern consistently across "今日热议" (Today Hot), "最热节点" (Hot Nodes), "新增节点" (New Nodes), and "节点导航" (Node Navigation) sections
Comment on lines
+58
to
+61
| } header: { | ||
| SectionTitleView("今日热议") | ||
| .listRowInsets(EdgeInsets()) | ||
| .listRowBackground(Color.itemBg) |
There was a problem hiding this comment.
The first section header includes .listRowInsets(EdgeInsets()) while the other three section headers (lines 75-76, 90-91, 105-106) do not. This inconsistency will cause the section titles to have different padding/insets, which may result in misaligned headers across the Explore page. All section headers should have consistent styling.
Code Coverage Report ❌Current coverage: 34.22% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ExplorePage.swift:今日热议section only shows whendailyHotInfois not empty最热节点section only shows whenhottestNodeInfois not empty新增节点section only shows whenrecentNodeInfois not empty节点导航section only shows whennodeNavInfois not emptyTest plan
🤖 Generated with Claude Code