chore: migrate to shared ios-certificates Match repository #71
Conversation
- Update Fastlane Match git_url to git@github.com:graycreate/ios-certificates.git - Deprecate old certificates-v2er-iOS repository - Share distribution certificates with other apps to avoid Apple's 3-cert limit - Generate new provisioning profiles for v2er.app in shared repo - Bump version to 1.1.19 for release pipeline testing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR migrates certificate management from a V2er-specific repository to a shared iOS certificates repository and bumps the app version to 1.1.19.
- Updates Fastlane Match configuration to use the new
ios-certificatesrepository - Increments MARKETING_VERSION from 1.1.18 to 1.1.19
- Adds a changelog entry documenting the infrastructure changes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fastlane/Matchfile | Updates git_url to point to the new shared ios-certificates repository |
| fastlane/Fastfile | Updates Match git_url in sync_certificates lane to match Matchfile |
| V2er/Config/Version.xcconfig | Bumps MARKETING_VERSION from 1.1.18 to 1.1.19 |
| CHANGELOG.md | Adds v1.1.19 entry documenting the certificate repository migration |
| ## v1.1.19 (Build XX) | ||
| 1. Infrastructure: Migrate certificate management to shared ios-certificates repository | ||
| 2. Improvement: Update Fastlane Match to use git@github.com:graycreate/ios-certificates.git | ||
| 3. Test: Verify release pipeline works with new Match repository configuration |
There was a problem hiding this comment.
The changelog entry includes a 'Test' item that describes testing the release pipeline. Changelog entries should describe changes delivered to end users, not internal testing activities. Consider removing this line or rephrasing it to describe the actual improvement (e.g., 'Improvement: Enhanced release pipeline reliability with updated certificate management').
| 3. Test: Verify release pipeline works with new Match repository configuration | |
| 3. Improvement: Enhanced release pipeline reliability with updated Match repository configuration |
|
|
||
| ## v1.1.19 (Build XX) | ||
| 1. Infrastructure: Migrate certificate management to shared ios-certificates repository | ||
| 2. Improvement: Update Fastlane Match to use git@github.com:graycreate/ios-certificates.git |
There was a problem hiding this comment.
[nitpick] This changelog entry exposes an internal Git URL which is implementation detail that doesn't benefit end users. Consider rephrasing to focus on the user-facing benefit, such as 'Improvement: Streamlined certificate management for more reliable builds'.
| 2. Improvement: Update Fastlane Match to use git@github.com:graycreate/ios-certificates.git | |
| 2. Improvement: Streamlined certificate management for more reliable builds |
Code Coverage Report ❌Current coverage: 19.06% |
Summary
certificates-v2er-iOSto sharedios-certificatesrepositorygit@github.com:graycreate/ios-certificates.gitChanges
fastlane/Matchfilewith new git_urlfastlane/Fastfilesync_certificates lane with new git_urlTesting
fastlane match appstore --readonlypassed successfullyAppStore_v2er.app.mobileprovisionDeploy Keys
MATCH_GIT_URLandDEPLOY_KEYhave been updatedios-certificateshas deploy key configured with write access🤖 Generated with Claude Code