pass env GITHUB_TOKEN #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
内置的github_token没办法对其他仓库修改，原来的token也是有效的，只是邮箱变成了未验证状态. |
Author
感谢提醒，我刚刚发现 actions 似乎有安全问题，想请帮忙确认一下 manual/.github/workflows/deploy.yml Lines 6 to 7 in d125369 manual/.github/workflows/deploy.yml Lines 20 to 21 in d125369 也就是说任何人都可以 fork 并修改 deploy.sh，然后提 PR，通过 token 对这个仓库做任何事情，是这样的吗 |
Contributor
|
看起来是的，可以把token发送出去，所以应该把pull关掉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.