Skip to content

Conversation

@JBWilkie
Copy link
Contributor

@JBWilkie JBWilkie commented Feb 18, 2025

Problem

This is an issue that was introduced by DAR-5605

It happens due to some deduplication logic. We parse the annotation frame-by-frame and check if the state of sub-annotations has changed. If it has, we include them in the annotation payload. If it doesn't, we do not

This is fine, since if attributes are left out of the payload entirely, backend doesn't wipe them for that frame. However, DAR-5605 fixed a bug where we weren't representing the transition from some attributes to no attributes correctly. It did this by including attributes: [] in the required places. Unfortunately, we also needed to add a check that only did this for keyframes. Not doing this causes BE to wipe the attributes for that frame

Solution

Do not skip duplicate video sub-annotations for keyframes

Changelog

Fixed edge case when importing attributes on video annotations

@linear
Copy link

linear bot commented Feb 18, 2025

@JBWilkie JBWilkie merged commit 8ff8d6e into master Feb 18, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants