[DAR-5903][External] Do not skip duplicate video sub-annotations for keyframes #1005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is an issue that was introduced by DAR-5605
It happens due to some deduplication logic. We parse the annotation frame-by-frame and check if the state of sub-annotations has changed. If it has, we include them in the annotation payload. If it doesn't, we do not
This is fine, since if attributes are left out of the payload entirely, backend doesn't wipe them for that frame. However, DAR-5605 fixed a bug where we weren't representing the transition from some attributes to no attributes correctly. It did this by including
attributes: []in the required places. Unfortunately, we also needed to add a check that only did this for keyframes. Not doing this causes BE to wipe the attributes for that frameSolution
Do not skip duplicate video sub-annotations for keyframes
Changelog
Fixed edge case when importing attributes on video annotations