[DAR-6195][external] Support Reports v3 in Darwin Py #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbertoDifa
reviewed
Apr 15, 2025
Collaborator
umbertoDifa
left a comment
umbertoDifa
left a comment
There was a problem hiding this comment.
Looks good! I've added a few discussion point we should discuss about
vvihorev
commented
Apr 16, 2025
AndriiKlymchuk
approved these changes
Apr 16, 2025
umbertoDifa
reviewed
Apr 16, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
darwin/client.py:720
- The symbol 'urljoin' is used but not imported; add 'from urllib.parse import urljoin' at the top of the file.
raise JobPendingException(f"Polling for generated report results timed out, job status can be requested manually: {urljoin(self.url, job_status_url)}")
tests/darwin/client_test.py:826
- The exception 'NotFound' is used in the test but does not appear to be imported or defined; ensure it is imported from the appropriate module or replace it with the correct exception.
with pytest.raises(NotFound):
vvihorev
force-pushed
the
dar-6195-add-ability-to-query-reports_v3-through-the-sdk
branch
from
f1ebfd2 to
fbf580b
Compare
Contributor
|
Looks good |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
umbertoDifa
approved these changes
Apr 17, 2025
vvihorev
deleted the
dar-6195-add-ability-to-query-reports_v3-through-the-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is impossible to query V3 annotator reports using the SDK. Reports V1 can be queried, but are not created since 11/05/2024.
Solution
Add a new top-level command and an action for V3 annotator reports:
darwin report annotators.Instead of requesting an annotator report synchronously, start a report job, and poll for results with exponential backoff. For now, log the id of the created job and raise an error if the happy path fails.
Changelog
Added top-level
reportcommand, addedreport annotatorscommand to query V3 annotator reports