[DAR-6481][external] Remove 'dataset report' command #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated "darwin dataset report" command and its associated methods to streamline the reporting commands.
- Removed the "report" parser and its arguments from the CLI options.
- Removed the get_report methods and related client functionality.
- Updated the CLI command routing to eliminate report handling.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| darwin/options.py | Removed the "report" parser for dataset command. |
| darwin/dataset/remote_dataset_v2.py | Removed the get_report method and unused import. |
| darwin/dataset/remote_dataset.py | Removed the abstract get_report method from the dataset interface. |
| darwin/client.py | Removed the get_report implementation from the client class. |
| darwin/cli_functions.py | Removed the dataset_report function and its logic. |
| darwin/cli.py | Removed the CLI branch for the "report" command. |
vvihorev
changed the title
umbertoDifa
approved these changes
Apr 18, 2025
AndriiKlymchuk
approved these changes
Apr 18, 2025
…for-querying-v1-reports-in
vvihorev
deleted the
dar-6481-deprecate-dataset-report-command-for-querying-v1-reports-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
V1 Reports are no longer generated, a top-level
darwin report annotatorcommand was added for V3 reports, anddarwin dataset reportcan be deprecated.Solution
Remove the command, and the methods used by it.
Changelog
Remove
darwin dataset reportcommand.