Skip to content

Conversation

@umbertoDifa
Copy link
Collaborator

@umbertoDifa umbertoDifa commented Apr 18, 2025

Problem

  1. We must avoid being notified of a failure late after the code is merged.
  2. We must avoid being notified about an e2e failure only after the nightly run
  3. If multiple PRs are merged to master only the last one runs the full GHA

Solution

  1. Run unit tests for each PR (Ideally we'd run e2e but curretly it takes 45min so not worth it)
  2. Run e2e for each merge to master
  3. Remove concurrency so that each commit to master gets its own full run. This is important cause in case of multiple PRs we can quickly identify which commit is responsible of a failure (otherwise we wouldn't know what introduced a failure and we'd need to revert them all)

Copilot AI review requested due to automatic review settings April 18, 2025 09:08
@umbertoDifa umbertoDifa requested a review from vvihorev April 18, 2025 09:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve early defect detection by shifting testing left in the development process. It introduces unit tests on pull requests and incorporates e2e tests during merges to master.

  • Added a pull_request trigger with branch filters in JOB_tests.yml to run unit tests on PRs.
  • Updated EVENT_merge_to_master.yml to add an e2e_tests job and include it as a dependency for notification jobs.
  • Adjusted Slack notification message formatting for consistency.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/JOB_tests.yml Added pull_request trigger with branch filters to run tests for PRs.
.github/workflows/EVENT_merge_to_master.yml Introduced e2e_tests job and updated dependency arrays for warn_on_fail and success notifications.

@umbertoDifa umbertoDifa enabled auto-merge (squash) April 18, 2025 09:09
@umbertoDifa umbertoDifa merged commit 4f801a0 into master Apr 30, 2025
23 checks passed
@umbertoDifa umbertoDifa deleted the improve-gha branch April 30, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants