Skip to content

[internal] Shift left testing #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

[internal] Shift left testing #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d512ba
Run tests on each PR
umbertoDifa Apr 18, 2025
9a15e9b
Run e2e every time a PR is merged in master
umbertoDifa Apr 18, 2025
9ffdf7d
Remove master concurrency
umbertoDifa Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/EVENT_merge_to_master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@ on:

permissions:
contents: read
id-token: write # Necessary for the generate documentation job

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
id-token: write # Necessary for the generate documentation job

jobs:

run_tests:
name: Run tests
uses: ./.github/workflows/JOB_tests.yml

e2e_tests:
name: E2E Tests
uses: ./.github/workflows/JOB_e2e.yml
secrets: inherit

documentation:
name: Documentation
uses: ./.github/workflows/JOB_generate_documentation.yml
Expand All @@ -30,18 +30,18 @@ jobs:
contents: read

warn_on_fail:
needs: [run_tests, documentation]
needs: [run_tests, e2e_tests, documentation]
if: ${{ failure() }}
name: Slack message us on fail
uses: ./.github/workflows/JOB_slack_message.yml
secrets: inherit
with:
at_team: true
icon: ':warning:'
message: 'Master is failing after a push event, please review at ${{ github.event.repository.html_url }}/actions/runs/${{ github.run_id }}'
icon: ":warning:"
message: "Master is failing after a push event, please review at ${{ github.event.repository.html_url }}/actions/runs/${{ github.run_id }}"

success:
needs: [run_tests, documentation]
needs: [run_tests, e2e_tests, documentation]
if: ${{ success() }}
name: Success
runs-on: ubuntu-latest
Expand All @@ -64,4 +64,4 @@ jobs:
repo: context.repo.repo,
sha: context.sha,
state: 'success'
})
})
4 changes: 3 additions & 1 deletion .github/workflows/JOB_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ run-name: Tests

on:
workflow_call:
pull_request:
branches: [main, master]

permissions:
contents: read
Expand Down Expand Up @@ -48,7 +50,7 @@ jobs:
pip install wheel && \
pip install --upgrade setuptools && \
pip install --editable '.[test,ml,medical,dev, ocv]'"

- name: Install ffmpeg (Ubuntu)
if: matrix.os == 'ubuntu-latest'
shell: bash
Expand Down