Skip to content

Conversation

@AndriiKlymchuk
Copy link
Contributor

Problem

When importing mask annotations for a video item, darwin-py skips them with next warning:
[WARNING] Unsupported annotation type: 'dict_keys(['keyframe', 'mask', 'name', 'id'])'

Solution

Add logic for reorganizing such annotations as valid once.

Changelog

Fixed bug when it is not possible to import mask annotations for a video

@linear
Copy link

linear bot commented Sep 26, 2023

ANN-2555 BUG: The Precision Planting team has reported an issue when importing mask annotations

BUG submission from: Muata Hunt
Summary (describe an issue):
The Precision Planting team has reported an issue when importing mask annotations.

According to the team, when they import mask annotations via SDK or CLI, they receive error messages saying this: "[WARNING] Unsupported annotation type: 'dict_keys(['keyframe', 'mask', 'name', 'id'])'
[WARNING] Unsupported annotation type: 'dict_keys(['keyframe', 'raster_layer', 'name', 'id'])'"

I've tested this on my side and I receive this error message on the latest version of darwin-py and the previous few versions, as well. It's important to note that I was able to import mask annotations for images without any issues.
Has the strategic customer been impacted or reported the issue?
YES ⚠️
Share Loom/Screenshots with Console/Network opened:
N/A
Darwin affected version
V2
Environment (production/staging; browser and OS version)
V2 prod
Impact
All (all Darwin users are impacted)
Priority
Urgent - blocking with no workaround or urgent for a top-tier at churn risk
Steps to reproduce

  1. On a video file, make a mask annotation.
  2. Select the video and export it.
  3. Once exported, use CLI or SDK to re-import the annotation.
  4. Observe if you receive an error message upon importing.
    Expected Behaviour
    Mask annotations for videos should be re-importable if the Darwin JSON schema is correct.
    Team & Dataset Link
    Team - https://darwin.v7labs.com/super_admin/teams/4227
    Intercom ticket
    https://app.intercom.com/a/inbox/pb9z3asr/inbox/admin/5720549/conversation/282610?view=List
    ARR
    20000
    Assigned CSM
    Nell Norman

Copy link
Contributor

@owencjones owencjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a bug fix, untested. Could you raise an IO ticket, with label 'darwin-py' for adding a happy path / sad path test and we'll handle that?

@AndriiKlymchuk
Copy link
Contributor Author

Looks good as a bug fix, untested. Could you raise an IO ticket, with label 'darwin-py' for adding a happy path / sad path test and we'll handle that?

Done - https://linear.app/v7labs/issue/IO-1812/cover-datatypes-module-by-tests

@AndriiKlymchuk AndriiKlymchuk merged commit 282c38d into master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants