Skip to content

Conversation

@JBWilkie
Copy link
Contributor

Problem

In the original PR for IO-1496, edges were returned as a list of lists, with each item containing:

  • edge_id
  • source_stage_id
  • target_stage_it

But, it makes more sense for the entire object to be returned in favour of the IDs within

Solution

Return WFEdgeCore objects instead of the IDs within them

Changelog

Ensure edges are returned as WFEdgeCore objects

@linear
Copy link

linear bot commented Oct 20, 2023

IO-1496 Stage is missing name, type, and edges

The Stage object doesn't expose name, type, or edges members.

Add these, as properties with loading if necessary.

Acceptance criteria

  • Accessing name on Stage returns the name as a string
  • Accessing type on Stage returns the type as an Enum/appropriate type
  • Accessing edges on Stage returns the edges as a List

@JBWilkie JBWilkie requested a review from Nathanjp91 October 20, 2023 10:44
@Nathanjp91 Nathanjp91 merged commit b0953bf into master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants