[IO-1801][external] Core item archive method & tests #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IO-1801 Core: Edit items: Archive
|
JBWilkie
commented
Oct 26, 2023
| raise Unauthorized(response) | ||
| if response.status_code == 404: | ||
| raise NotFound(response) | ||
| if response.status_code == 422: |
Contributor
Author
There was a problem hiding this comment.
We may want to surface / deal with / pprint 422s later, especially because the endpoints generally do a good job of pointing out exactly what causes 422s
owencjones
suggested changes
Oct 27, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
Only one change, and it's really minor lint change at the bottom - this is good stuff mate.
| responses.add( | ||
| responses.POST, | ||
| base_client.config.api_endpoint + "v2/teams/test-team/items/archive", | ||
| json={"affected_item_count": 0}, |
Contributor
There was a problem hiding this comment.
Really minor point, but your affect item count here is mocked as 0, when if successful, it would've been 2.
Honestly, only fix if you want to.
| assert response == {"affected_item_count": 0} | ||
|
|
||
|
|
||
| def test_archive_items_with_error_response(base_client: ClientCore) -> None: |
Contributor
There was a problem hiding this comment.
base_client fixture is included but not used here.
owencjones
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently no way to archive items in
darwin.futureSolution
Define the core method to archive a list of items by their UUIDs by using the archive endpoint
Changelog
Added core item archive method & tests