Skip to content

Allow filtering syscall tracing by name#2

Merged
rslota merged 2 commits intomainfrom
rafal.s/revup/main/allow-syscall-filtering
Feb 20, 2026
Merged

Allow filtering syscall tracing by name#2
rslota merged 2 commits intomainfrom
rafal.s/revup/main/allow-syscall-filtering

Conversation

@rslota
Copy link
Copy Markdown

@rslota rslota commented Feb 20, 2026

No description provided.

@rslota
Copy link
Copy Markdown
Author

rslota commented Feb 20, 2026

Reviews in this chain:
#2 Allow filtering syscall tracing by name

@rslota
Copy link
Copy Markdown
Author

rslota commented Feb 20, 2026

# head base diff date summary
0 6d799685 427a050e diff Feb 20 11:38 AM 2 files changed, 22 insertions(+), 4 deletions(-)
1 b8b010f7 427a050e diff Feb 20 11:42 AM 2 files changed, 2 insertions(+), 2 deletions(-)
2 f951ea88 427a050e diff Feb 20 11:55 AM 1 file changed, 1 insertion(+), 3 deletions(-)
3 de134a77 427a050e diff Feb 20 11:59 AM 2 files changed, 11 insertions(+), 5 deletions(-)

@rslota rslota requested review from balysv, erszcz and kzemek February 20, 2026 10:38
Comment thread src/syscall_trace.rs Outdated
Comment on lines +117 to +118
if let Some(ref filter) = self.filter
&& !filter.iter().any(|f| f == syscall)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if let Some(ref filter) = self.filter
&& !filter.iter().any(|f| f == syscall)
if self.filter.as_ref().is_some_and(|filter| !filter.contains(syscall)) {

@rslota rslota force-pushed the rafal.s/revup/main/allow-syscall-filtering branch from b8b010f to f951ea8 Compare February 20, 2026 10:55
@rslota rslota requested a review from kzemek February 20, 2026 10:55
Comment thread src/main.rs Outdated
Comment on lines +170 to +173
let filter = trace_filter.map(|f| {
f.split(',').map(|s| s.trim().to_string()).collect::<Vec<_>>()
});
let filter_log = filter.as_ref().map(|f| f.join(","));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let filter = trace_filter.map(|f| {
f.split(',').map(|s| s.trim().to_string()).collect::<Vec<_>>()
});
let filter_log = filter.as_ref().map(|f| f.join(","));
let filter_log = trace_filter.map(|f| {
f.split(',')
.map(|s| s.trim())
.collect::<Vec<_>>()
.join(",")
});

Allow filtering syscall tracing by name
@rslota rslota merged commit a9bc569 into main Feb 20, 2026
2 checks passed
rslota added a commit that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants