Skip to content

Fix file permissions from read-only to read-write (0o444 -> 0o644)#6

Merged
dant2021 merged 1 commit intomainfrom
fix/file-permissions
Mar 17, 2026
Merged

Fix file permissions from read-only to read-write (0o444 -> 0o644)#6
dant2021 merged 1 commit intomainfrom
fix/file-permissions

Conversation

@dant2021
Copy link
Copy Markdown

Summary

  • Change file permission bits from 0o444 (read-only for all) to 0o644 (read-write for owner, read-only for group/others) in src/fuse_fs.rs

Test plan

  • Mount the filesystem and verify files are accessible with the correct permissions (-rw-r--r--)

@simedw simedw requested a review from rslota March 16, 2026 18:45
@simedw
Copy link
Copy Markdown

simedw commented Mar 16, 2026

any downsides with this @rslota
(the reason for this is that when the agent copy the files over from /mnt/lazy it keeps the same permission, which leads to a bunch of errors)

@rslota
Copy link
Copy Markdown

rslota commented Mar 16, 2026

any downsides with this @rslota (the reason for this is that when the agent copy the files over from /mnt/lazy it keeps the same permission, which leads to a bunch of errors)

quoting what I write on slack:

but... this may have a very bad effect on LLM in general, suggesting those files are writable, but they aren't
better fix is to make askexcel skill change mod or askexcel itself do it

@simedw
Copy link
Copy Markdown

simedw commented Mar 17, 2026

can we alias cp to cp --no-preserve=mode ?

@dant2021
Copy link
Copy Markdown
Author

but... this may have a very bad effect on LLM in general, suggesting those files are writable, but they aren't
better fix is to make askexcel skill change mod or askexcel itself do it

I disagree here, for multiple reasons.

  • all the skills and scripts in the repo are 644.
  • there might be other skills that copy the input, if we fix in ask excel its more duplication and possible to miss some
  • llm's never check metadata before attempting to read/write to a file (otherwise claude would stop trying to read 50MB jsons)

The files are not writable because blocked at directory level and that also described in the system prompt.
sandcastle/worker/system_prompt_infra.py

 `/mnt/lazy` - Read-only mount for large input files (downloaded on first access).

Copy link
Copy Markdown

@simedw simedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep an eye on this to make sure this doesn't introduce any confusion for the model

@dant2021
Copy link
Copy Markdown
Author

can we alias cp to cp --no-preserve=mode ?

fyi this would not work either because some agent runs might write a shutil in python

@dant2021 dant2021 merged commit e7e06bd into main Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants