feat: support Signals in multi-user context API#59
Merged
Conversation
`BrowserlessApplicationContext` / `BrowserlessUserContext` / `BrowserlessUIContext` did not register the test `SignalEnvironment`, so signal effects ran on the real thread pool and tests driving the context API could not flush them deterministically. Two smaller DSL methods — `fireShortcut` and `test(Class, Y)` — were also missing compared to `BrowserlessTest`. Register `TestSignalEnvironment` over the application context lifecycle and expose `runPendingSignalsTasks`, `fireShortcut`, and the explicit tester `test(Class, Y)` on `BrowserlessUIContext`.
mshabarov
reviewed
May 12, 2026
Strengthen `applicationContextClose_unregistersSignalEnvironment` to directly verify both that `BrowserlessApplicationContext` clears its `signalsTestEnvironment` reference and that the global signal registry no longer routes through the (now orphaned) test queue.
mshabarov
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrowserlessApplicationContext/BrowserlessUserContext/BrowserlessUIContextdid not register the testSignalEnvironment, so signal effects ran on the real thread pool and tests driving the context API could not flush them deterministically. Two smaller DSL methods —fireShortcutandtest(Class, Y)— were also missing compared toBrowserlessTest.Register
TestSignalEnvironmentover the application context lifecycle and exposerunPendingSignalsTasks,fireShortcut, and the explicit testertest(Class, Y)onBrowserlessUIContext.