Skip to content

chore: add a note about .npmrc customization #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2025
Merged

chore: add a note about .npmrc customization #4459

merged 3 commits into from
Aug 13, 2025

Conversation

@mcollovati
Copy link
Contributor

@mcollovati mcollovati commented Aug 6, 2025

Fixes #4458

@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

AI Language Review

The only change between the files is the additional information about using PNPM with the .npmrc file. The added line suggests removing the auto-generated notice to prevent Vaadin from overwriting customizations:

  • The instruction is useful, but it could be more explicit. It's unclear if the removal of the notice applies only when PNPM is used or in general. Consider rephrasing for clarity: "When using PNPM, ensure to remove the NOTICE: this is an auto-generated file comment from the .npmrc file to prevent Vaadin from overwriting it with default contents."

This would help clarify that the instruction is specific to PNPM scenarios.

@peholmst peholmst added the target/main cherry pick to main branch label Aug 8, 2025
@mcollovati mcollovati added the flow label Aug 8, 2025
@mshabarov mshabarov requested a review from caalador August 11, 2025 11:44
@caalador caalador merged commit 894c21f into v24 Aug 13, 2025
4 checks passed
@caalador caalador deleted the chore/custom-npmrc branch August 13, 2025 03:50
vaadin-bot pushed a commit that referenced this pull request Aug 20, 2025
@mcollovati @vaadin-bot
chore: add a note about .npmrc customization (#4459)
e37d56f 
Fixes #4458
peholmst pushed a commit that referenced this pull request Aug 20, 2025
@vaadin-bot @mcollovati
chore: add a note about .npmrc customization (#4459) (#4517)
ffe5c9c 
Fixes #4458

Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caalador caalador caalador approved these changes

Assignees

No one assigned

Labels

cherry-picked-main flow target/main cherry pick to main branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document how to preserve custom .npmrc content when using PNPM

5 participants

@mcollovati @caalador @peholmst @vaadin-bot