Skip to content

Fix upload progress tracking link in File Handling page #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2025
Merged

Fix upload progress tracking link in File Handling page #4583

merged 2 commits into from
Sep 15, 2025

Conversation

@HerbertsVaadin
Copy link
Contributor

@HerbertsVaadin HerbertsVaadin commented Sep 9, 2025

Previously it linked to a section that no longer exists.

@github-actions
Copy link

github-actions bot commented Sep 9, 2025 •
edited
Loading

AI Language Review

In the file "File Handling", the following improvements are needed:

  1. In the sentence, "All of the build-in implementations extend [classname]TransferProgressAwareHandler", "build-in" should be corrected to "built-in".

  2. The cross-reference "<<add-progress-listener, adding progress listeners>>" has been updated to "<<#upload-progress-tracking, upload progress tracking>>". Ensure the cross-reference correctly links within the document.

These corrections enhance clarity and ensure correct term usage.

@HerbertsVaadin HerbertsVaadin added the target/main cherry pick to main branch label Sep 9, 2025
@peholmst peholmst merged commit 365c5d4 into v24 Sep 15, 2025
4 checks passed
@peholmst peholmst deleted the bugfix/file-handling-link branch September 15, 2025 06:25
vaadin-bot pushed a commit that referenced this pull request Sep 15, 2025
@HerbertsVaadin @peholmst @vaadin-bot
Fix upload progress tracking link (#4583)
d0407d8 
Co-authored-by: Petter Holmström <petter@vaadin.com>
peholmst added a commit that referenced this pull request Sep 15, 2025
@vaadin-bot @HerbertsVaadin @peholmst
Fix upload progress tracking link (#4583) (#4592)
119b3da 
Co-authored-by: Herberts <80950643+HerbertsVaadin@users.noreply.github.com>
Co-authored-by: Petter Holmström <petter@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peholmst peholmst peholmst approved these changes

Assignees

No one assigned

Labels

cherry-picked-main target/main cherry pick to main branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HerbertsVaadin @peholmst @vaadin-bot