Skip to content

feat: document NpmPackage npm assets (#4513) (CP: v24) #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

feat: document NpmPackage npm assets (#4513) (CP: v24) #4648

merged 1 commit into from
Oct 13, 2025

Conversation

@vaadin-bot
Copy link
Contributor

@vaadin-bot vaadin-bot commented Oct 8, 2025

No description provided.

@caalador @tltv
@jouni @mshabarov @vaadin-bot
feat: document NpmPackage npm assets (#4513)
cebcf63 
* feat: document NpmPackage npm assets

Add documentation on copying
npm assets for NpmPackage.

part of vaadin/flow#21806

* minor chages/clarifications

update example

* Add info on npm stylesheet with cssimport

* Update articles/styling/advanced/npm-packages.adoc

Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>

* Remove mentions to old feature fron new feature.

# Conflicts:
#	articles/styling/advanced/npm-packages.adoc

* edits

* Update npm-packages.adoc

---------

Co-authored-by: Tomi Virtanen <tltv@vaadin.com>
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

AI Language Review

Here are the necessary corrections or improvements for the two AsciiDoc files:

  1. For the file Loading Theme Resources from npm Packages:
  • No specific issues were identified that require improvement in the modified sections of this document.
  1. For the file Importing Resources from npm Packages:
  • The heading "Using Static Resources from npm Packages" should spell out "and" in the title. Consider changing it to "Using Static Resources like Fonts, Icons, and Stylesheets from npm Packages" to maintain consistency with previous sections.

No other changes are required. The revised content is clear and maintains a professional tone.

@peholmst peholmst merged commit e52787b into v24 Oct 13, 2025
4 checks passed
@peholmst peholmst deleted the cherry-pick-4513-to-v24-1759908775225 branch October 13, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peholmst peholmst peholmst approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vaadin-bot @peholmst @caalador