Skip to content

Conversation

@vaadin-bot
Copy link
Contributor

No description provided.

* docs: improve Kubernetes Kit configuration documentation

Fixes vaadin/kubernetes-kit#248

* vale fixes

* Apply suggestion

* Update articles/tools/kubernetes/configuration.adoc

Co-authored-by: Giovanni Lovato <giovanni@vaadin.com>

---------

Co-authored-by: Giovanni Lovato <giovanni@vaadin.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

AI Language Review

The following issues require improvement in the Configuration document:

  1. In the section "Hazelcast for Session Replication," the sentence "The service-name and service-port properties defines the endpoint..." should have "defines" changed to "define" to match the plural subject.

  2. The note about Hazelcast's shutdown hook appears after an example using the .yaml configuration. It might be more contextually coherent to move this note before the examples to ensure that the reader does not miss this important information.

  3. In the block note explaining Hazelcast's shutdown hook, the sentence "Spring takes care of automatically gracefully stop the Hazelcast instance..." should be revised to "Spring automatically takes care of gracefully stopping the Hazelcast instance..." for better clarity and grammar.

These changes will improve clarity and grammatical accuracy in the document.

@peholmst peholmst merged commit f589a66 into main Dec 4, 2025
4 checks passed
@peholmst peholmst deleted the cherry-pick-4827-to-main-1764788470412 branch December 4, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants