Commit 6f8750a
fix: style spreadsheet overlays when nested in a shadow root (#9713)
Since #9303, spreadsheet overlays (context menu, popup-button filters,
cell comments, tooltips) live in a `#spreadsheet-overlays` container in
the component's light DOM, styled by a global `<style>` in
`document.head`. When `<vaadin-spreadsheet>` is nested in another
element's shadow root — for example embedded as a web component, as in
the docs filtering example — the container ends up inside that shadow
tree, which the document-level stylesheet cannot cross, so the overlays
render unstyled.
To reproduce: open the [docs "spreadsheet filtering"
example](https://vaadin.com/docs/latest/example?embed=spreadsheet-filtering-wc.js&import=component/spreadsheet/spreadsheet-imports.ts)
(the spreadsheet is embedded as a web component) and open a column
filter — the popup shows with no rounded corners, background, or shadow.
On attach, also adopt the overlay stylesheet onto the container's own
root (`this._overlays.getRootNode()`) when that root is a `ShadowRoot`,
so the scoped `#spreadsheet-overlays …` rules apply inside the shadow
tree. Top-level usage is unchanged: the root is the document, already
covered by the existing `document.head` stylesheet.
Follow-up to #9303
---
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01QjNdPXWEUciMEXQe9hMgMt
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent 305bb4b commit 6f8750a
3 files changed
Lines changed: 123 additions & 0 deletions
File tree
- vaadin-spreadsheet-flow-parent
- vaadin-spreadsheet-flow-integration-tests/src
- main/java/com/vaadin/flow/component/spreadsheet/tests
- test/java/com/vaadin/flow/component/spreadsheet/test
- vaadin-spreadsheet-flow/src/main/resources/META-INF/frontend/vaadin-spreadsheet
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
Lines changed: 54 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
182 | 192 | | |
183 | 193 | | |
184 | 194 | | |
| |||
0 commit comments