Skip to content

feat: add HasSize to Details#2274

Merged
sosa-vaadin merged 4 commits into
masterfrom
fix/hasSizeDetails
Nov 2, 2021
Merged

feat: add HasSize to Details#2274
sosa-vaadin merged 4 commits into
masterfrom
fix/hasSizeDetails

Conversation

@jcgueriaud1

Copy link
Copy Markdown
Contributor

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes #1294

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

I didn't add any tests since there is no test for the other components.

@web-padawan web-padawan changed the title Add HasSize to Details feat: add HasSize to Details Oct 26, 2021
@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 1 issue

  1. MAJOR Details.java#L9: This block of commented-out lines of code should be removed. rule

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Details component should implement HasSize

4 participants