Skip to content

fix: enforce radio button web component disabled state (#2563)#2567

Merged
web-padawan merged 1 commit into
22.0from
fix-radio-button-disabled-cp
Jan 26, 2022
Merged

fix: enforce radio button web component disabled state (#2563)#2567
web-padawan merged 1 commit into
22.0from
fix-radio-button-disabled-cp

Conversation

@tomivirkki

@tomivirkki tomivirkki commented Jan 26, 2022

Copy link
Copy Markdown
Member

Turns out #2528 wasn't a regression after all, but also V22 and V14 suffer from it. Cherry-pick #2563 for V22

@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 5 issues

  1. CRITICAL RadioButtonGroup.java#L203: Define a constant instead of duplicating this literal "value" 3 times. rule
  2. CRITICAL RadioButtonGroup.java#L272: Remove usage of generic wildcard type. rule
  3. CRITICAL RadioButtonGroup.java#L309: Remove usage of generic wildcard type. rule
  4. MAJOR RadioButtonGroup.java#L483: Rename "dataProvider" which hides the field declared at line 82. rule
  5. MINOR RadioButtonGroup.java#L117: Move this constructor to comply with Java Code Conventions. rule

@web-padawan web-padawan merged commit 1b06cc2 into 22.0 Jan 26, 2022
@web-padawan web-padawan deleted the fix-radio-button-disabled-cp branch January 26, 2022 07:47
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with platform 22.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants