Skip to content

fix: clear filter debouncer on connector reset#8563

Merged
sissbruecker merged 4 commits intomainfrom
fix/combo-box-reset-filter-debouncer
Jan 30, 2026
Merged

fix: clear filter debouncer on connector reset#8563
sissbruecker merged 4 commits intomainfrom
fix/combo-box-reset-filter-debouncer

Conversation

@sissbruecker
Copy link
Contributor

@sissbruecker sissbruecker commented Jan 29, 2026

Description

Currently a combo box can get stuck in a loading state if it is closed right after a filter change. The flow is something like:

  • Changing filter runs data provider
    • Connector schedules debounced request
  • Closing calls connector.reset
    • Calls comboBox.clearCache
    • This set a _forceNextRequest flag internally
  • Debouncer fires
    • Loads data from server, puts it into cache
  • Combo box is opened again
    • _forceNextRequest causes cached data to be ignored
    • Calls data provider again
    • Data communicator ignores request as data is already there
    • Loading state is never resolved

This fix changes connector.reset so that is also cancels any debounced requests, so that the connector will not attempt to load data after a reset and while the component is closed.

Fixes #8235

Type of change

  • Bugfix

@sissbruecker sissbruecker marked this pull request as ready for review January 30, 2026 06:50
@sissbruecker sissbruecker enabled auto-merge (squash) January 30, 2026 13:14
@sonarqubecloud
Copy link

@sissbruecker sissbruecker merged commit 1ba1170 into main Jan 30, 2026
5 checks passed
@sissbruecker sissbruecker deleted the fix/combo-box-reset-filter-debouncer branch January 30, 2026 13:30
@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @sissbruecker, when i performed cherry-pick to this commit to 24.10, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 1ba1170
error: could not apply 1ba1170... fix: clear filter debouncer on connector reset (#8563)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @sissbruecker, when i performed cherry-pick to this commit to 25.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 1ba1170
error: could not apply 1ba1170... fix: clear filter debouncer on connector reset (#8563)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @sissbruecker, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 1ba1170
error: could not apply 1ba1170... fix: clear filter debouncer on connector reset (#8563)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

DiegoCardoso pushed a commit that referenced this pull request Jan 30, 2026
) (#8580)

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
DiegoCardoso pushed a commit that referenced this pull request Jan 30, 2026
) (#8581)

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultiSelectComboBox overlay is loading infinitely

3 participants